Skip to content

Resolve CSS Regression #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 1, 2024
Merged

Resolve CSS Regression #5976

merged 4 commits into from
May 1, 2024

Conversation

smithellis
Copy link
Contributor

  • New _messages.scss for inbox, outbox
  • New inbox.html, outbox.html

@smithellis smithellis requested a review from escattone April 24, 2024 19:07
This was referenced Apr 24, 2024
Closed
Closed
@smithellis smithellis requested a review from akatsoulas April 25, 2024 02:48
escattone
escattone requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely better, but I have some questions and one request for a change.

@smithellis smithellis force-pushed the css-regressions branch 2 times, most recently from d07ce50 to 98941f0 Compare April 29, 2024 19:16
escattone
escattone requested changes Apr 29, 2024
View reviewed changes
escattone
escattone reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one more thing. What do you think about just leaving the To Users or To Groups columns blank instead of inserting None when there are no users or groups? I think I'd prefer that.

akatsoulas
akatsoulas reviewed Apr 30, 2024
View reviewed changes
@smithellis smithellis mentioned this pull request Apr 30, 2024
Closed
@smithellis
Resolve CSS Regression
de3513f 
* New _messages.scss for inbox, outbox
* New inbox.html, outbox.html
@smithellis
Requested changes:
af2ea1b 
- Drop Delete Selected from inbox, outbox
- Drop checkboxes from Outbox
- Repair scss
@smithellis
typos
7209381
akatsoulas
akatsoulas reviewed May 1, 2024
View reviewed changes
@smithellis
Updates include:
e8789bf 
- Switch from divs to li
- Switch from grid to flex
- Actually make the 'read' css class work
- Display blank instead of "None" if there is no group or user
- Message delete correction
escattone
escattone approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

I liked the different color shadings you used for alternate message rows prior to this latest change when you moved from grid to flex. Would it be easy to bring those back?

@smithellis smithellis merged commit 931e261 into mozilla:main May 1, 2024
2 checks passed
@smithellis smithellis deleted the css-regressions branch May 1, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akatsoulas akatsoulas akatsoulas left review comments

@escattone escattone escattone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithellis @akatsoulas @escattone